[openib-general] [PATCH] IPOIB: initialization patch in ipoib

Roland Dreier roland at topspin.com
Thu Feb 24 10:46:36 PST 2005


Thanks, applied except for this bit:

 >	@@ -673,6 +674,7 @@ static void ipoib_neigh_destructor(struc
 >	                        ipoib_put_ah(neigh->ah);
 >	                list_del(&neigh->list);
 >	                *to_ipoib_neigh(n) = NULL;
 >	+               n->ops->destructor = NULL;
 >	                kfree(neigh);
 >	        }

This doesn't seem necessary to me, because we are actually in the call
to the neighbour destructor.  So the neighbour struct will be freed
right after we return and there's no risk of another call.

Thanks,
 Roland



More information about the general mailing list