[openib-general] Re: [PATCH] process_mad extension
Michael S. Tsirkin
mst at mellanox.co.il
Mon Jan 10 08:59:38 PST 2005
Hello!
Quoting r. Roland Dreier (roland at topspin.com) "Re: [PATCH] process_mad extension":
> Michael> Ok, I addressed all of these except the "C++-style"
> Michael> comment which I dont understand. Roland - how are these
> Michael> parameters in my code different from the next line where
> Michael> I see struct mad* in_mad? What is C++ about them?
>
> Compare the spacing of 'ib_grh* ' with 'ib_mad *':
>
> + struct ib_grh* in_grh,
> struct ib_mad *in_mad,
>
> I call declarations like "type* name" C++-style since Stroustrap seems
> to use it in his book.
Oh. Sorry about that. I wish whitespace issues were documented
better in Documentation/CodingStyle. BTW Bjarne's surname is "Stroustrup".
> In any case I'll fix this up by hand and apply.
>
> Thanks,
> Roland
Oh, you shouldnt have bothered.
Thanks,
MST
More information about the general
mailing list