[openib-general] ip over ib throughtput

[Roland Dreier]

    Grant> I didn't figure out why, but moving this chunk to
    Grant> immediately before request_irq() worked fine. Normally I
    Grant> expect _probe_one to get called before _open... but maybe
    Grant> something else needed to happen before pci_enable_msi()
    Grant> could be called.

That's a little strange.  It could either be the pci_enable_msi() or
the MSGINT_MODE setting that needs to happen later.  What puzzles me
is that there's a call to tg3_init_hw() even after the request_irq,
which does a tg3_reset_hw() -- so why doesn't that mess up our
MSGINT_MODE?

In any case I'm glad someone is finally looking at enabling MSI
support in more drivers.  It would be really nice to get this upstream
so that MSI support starts getting some real testing on lots of
systems.

One detail that you should add before sending this upstream is that
SA_SHIRQ is not needed in MSI mode -- the driver can be sure that the
interrupt is not shared.

 - R.