[openib-general] osm_sa_pkey_record.c when VENDOR_RMPP_SUPPORT defined

Hal Rosenstock halr at voltaire.com
Thu Jan 13 11:13:15 PST 2005


Hi Eitan,

It looks to me like osm_sa_pkey_record.c (line 513) is missing the #else
clause as shown below (and in all the other SA files where appropriate).
If you concur, I will generate the patch and apply.

#ifndef VENDOR_RMPP_SUPPORT
  /* we support only one packet RMPP - so we will set the first and
     last flags for gettable */
  if (p_rcvd_mad->method == IB_MAD_METHOD_GETTABLE_RESP)
  {
    p_resp_sa_mad->rmpp_type = IB_RMPP_TYPE_DATA;
    p_resp_sa_mad->rmpp_flags = IB_RMPP_FLAG_FIRST | IB_RMPP_FLAG_LAST |
IB_RMPP_FLAG_ACTIVE;
  }
#endif

missing else clause:

#else
  /* forcefully define the packet as RMPP one */
  if (p_resp_sa_mad->method == IB_MAD_METHOD_GETTABLE_RESP)
    p_resp_sa_mad->rmpp_flags = IB_RMPP_FLAG_ACTIVE;

Thanks.

-- Hal




More information about the general mailing list