[openib-general] Re: [PATCH 3/27] Add MAD helper functions

[Alexey Dobriyan]

On Monday 11 July 2005 17:48, Hal Rosenstock wrote:
> Add new helper routines for allocating MADs for sending and formatting
> a send WR.

> -- linux-2.6.13-rc2-mm1/drivers/infiniband2/core/mad.c
> +++ linux-2.6.13-rc2-mm1/drivers/infiniband3/core/mad.c
				   ^^^^^^^^^^^
Ick. You'd better have linux-2.6.13-rc2-mm1-[0123...].

> +struct ib_mad_send_buf * ib_create_send_mad(struct ib_mad_agent *mad_agent,
> +					    u32 remote_qpn, u16 pkey_index,
> +					    struct ib_ah *ah,
> +					    int hdr_len, int data_len,
> +					    int gfp_mask)

unsigned int __nocast gfp_mask, please. 430 or so infiniband sparse warnings
is not a reason to add more.

> +{

> +	buf = kmalloc(sizeof *send_buf + buf_size, gfp_mask);