[openib-general] Re: [PATCH] fork support

Roland Dreier rolandd at cisco.com
Mon Jul 18 05:15:00 PDT 2005


Thanks for doing this.  I'm actually at the Kernel Summit right now,
so I'll see what lobbying I can do.  Overall looks good, although I
have a few comments:

 - This patch allows userspace to remove VM_DONTCOPY from vmas even if
   the kernel set it.  Right now, VM_DONTCOPY is not used except for a
   couple of DRM drivers, so I'm not sure if this matters or not.  If
   it is a problem, I guess the answer is to create a VM_USERDONTCOPY
   that works just like VM_DONTCOPY and have PROT_DONTCOPY affect that.

 - I know this isn't your fault, but is it time to try and move all
   the common PROT_XXX defines somewhere to avoid so much duplication?

 - R.



More information about the general mailing list