[openib-general] Re: [PATCHv3] ucm: Only print messages when debug level set

Libor Michalek libor at topspin.com
Tue Jul 19 17:14:53 PDT 2005


On Wed, Jul 13, 2005 at 07:40:07PM -0400, Hal Rosenstock wrote:
> ucm: Only print messages when debug level set

  I don't think you can assume that ucm_debug_level will always be 
initialized correctly, or is module_param_named clearing it? Otherwise
looks fine...

-Libor 

> Signed-off-by: Hal Rosenstock <halr at voltaire.com>
> 
> --- ucm.c.kfree	2005-07-13 08:10:00.000000000 -0400
> +++ ucm.c	2005-07-13 19:39:04.000000000 -0400
> @@ -49,6 +49,11 @@ MODULE_AUTHOR("Libor Michalek");
>  MODULE_DESCRIPTION("InfiniBand userspace Connection Manager access");
>  MODULE_LICENSE("Dual BSD/GPL");
>  
> +static int ucm_debug_level;
> +
> +module_param_named(debug_level, ucm_debug_level, int, 0644);
> +MODULE_PARM_DESC(debug_level, "Enable debug tracing if > 0");
> +



More information about the general mailing list