[openib-general] Re: [PATCHv3] ucm: Only print messages when debug level set

[Gleb Natapov]

On Wed, Jul 20, 2005 at 10:35:07AM +0300, Michael S. Tsirkin wrote:
> Quoting r. Hal Rosenstock <halr at voltaire.com>:
> > Subject: Re: [PATCHv3] ucm: Only print messages when debug level set
> > 
> > On Tue, 2005-07-19 at 20:14, Libor Michalek wrote:
> > > On Wed, Jul 13, 2005 at 07:40:07PM -0400, Hal Rosenstock wrote:
> > > > ucm: Only print messages when debug level set
> > > 
> > >   I don't think you can assume that ucm_debug_level will always be 
> > > initialized correctly, or is module_param_named clearing it? Otherwise
> > > looks fine...
> > 
> > Same is true for IPoIB so it would need changing in both places if so.
> > 
> > -- Hal
> 
> I always thought that in C global storage is zero-initialized.
> What am I missing?
> 
Nothing, and if you initialise it explicitly you needlessly enlarge BSS.
There was kernel patches to remove zero initialisations while ago.

--
			Gleb.