[openib-general] Re: [PATCH] sdp_conn_put/sdp_conn_hold race

[Libor Michalek]

On Wed, Jul 20, 2005 at 09:44:18PM +0300, Michael S. Tsirkin wrote:
> Quoting r. Michael S. Tsirkin <mst at mellanox.co.il>:
> > The current sdp_conn_put/sdp_conn_hold implementation
> > seems to be subject to the following race condition:
> 
> Libor, did you have the time to review this patch?

  Yes, looks good. The only question I had was about making
sdp_conn_put an inline, and calling to destruct only on the
last decrement. Basically split the sdp_conn_put code in
your patch, where sdp_conn_put is everything before the
unlock of sock_lock, and destruct is everything after. Was
there any reason you didn't do that? Is there a reasont to
split it like this...

  Looks like all the right places have _light().

-Libor