[openib-general] Re: [PATCH] arch/xx/pci: remap_pfn_range -> io_remap_pfn_range
Greg KH
gregkh at suse.de
Wed Jul 27 23:58:47 PDT 2005
On Thu, Jul 28, 2005 at 09:48:59AM +0300, Michael S. Tsirkin wrote:
> Quoting r. Greg KH <gregkh at suse.de>:
> > Subject: Re: [PATCH] arch/xx/pci: remap_pfn_range -> io_remap_pfn_range
> >
> > On Tue, Jul 26, 2005 at 01:32:00AM +0300, Michael S. Tsirkin wrote:
> > > Greg, Martin, does the following make sense?
> > > If it does, should other architectures be updated as well?
> > >
> > Hm, you do realize that io_remap_pfn_range() is the same thing as
> > remap_pfn_range() on i386, right?
> >
> > So, why would this patch change anything?
> >
> > thanks,
> >
> > greg k-h
> >
>
> It doesnt change any behaviour.
> Its a style issue I'm trying to fix: even in arch specific code, isnt it better
> to use a generic io_remap_pfn_range to map PCI memory?
As I said above, it's the same thing on i386.
But, if you are getting picky, you should fix all of the other arches
too, right?
Anyway, why change this, I don't really see the need.
thanks,
greg k-h
More information about the general
mailing list