[openib-general][PATCH][kdapltest]: adding memtype options to server

James Lentini jlentini at netapp.com
Fri Jul 29 09:27:52 PDT 2005



On Fri, 29 Jul 2005, Guy German wrote:

> Hi James,
>
>>> Hi Guy,
>>> This patch has been garbled too. See below:
>
> I will resend all the garbled patches sunday morning
>
>>> -    ps_ptr->bpool = DT_BpoolAlloc (NULL,
>>> Something is missing here. If you remove the line above you can't
>>> replace it with the line below...
>>> + +    if (!(pt_ptr = DT_Alloc_Per_Test_Data (phead)))
>>> ...which has a double +
>
> Why not ?
>
> I replaced the first line :
>
> -    ps_ptr->bpool = DT_BpoolAlloc (NULL,
>
> with :
>
> + if (!(pt_ptr = DT_Alloc_Per_Test_Data (phead)))
> +    goto server_exit;
> +    DT_MemListInit (pt_ptr);
> +    memcpy ( (void *) (uintptr_t) &pt_ptr->Params,
> +             (const void *) params_ptr,
> +              sizeof (Params_t));
> +    ps_ptr->bpool = DT_BpoolAlloc (pt_ptr,
>
> What I basically did was allocating pt_ptr and
> copying the params to the ds before calling DT_BpoolAlloc.
> This time I call it with pt_ptr instead of NULL (that leads
> to default use of physical memory registration).
>
> (The + + has probably to do with mailer/diff problems)

I'll go through it again when you resend it.



More information about the general mailing list