[openib-general] [PATCH] kDAPL: cleanup dat/ a bit more

James Lentini jlentini at netapp.com
Thu Jun 2 08:36:44 PDT 2005



On Wed, 1 Jun 2005, Christoph Hellwig wrote:

hch> On Wed, Jun 01, 2005 at 11:23:44AM -0700, Tom Duffy wrote:
hch> > This patch cleans up dat/ a bit, removing unneeded parenthesis,
hch> > gratuitous comments, and a few whitespace cleanups.  Please apply.
hch> 
hch> btw, I think most of the code under dat/ should just go away ASAP.
hch> Just have a simple linked list of providers with trivial
hch> registration/unregisteration/find_get/put functions like all the other
hch> subsystems 

We have registration/unregistration functions for providers:

dat_registry_add_provider
dat_registry_remove_provider

Consumer's use 

dat_ia_openv
dat_ia_close
dat_registry_list_providers

Is this what you mean?

hch> and kill all the dictionaty mess 

The dictionary is implemented with a simple linked list. We could 
look into collapsing the code in api.c, dr.c and dictionary.c further.

hch> and provider vs provider_info braindamage.

What do you mean by provider vs provider_info? Are you suggesting 
adding the information in the dat_provider_info structure to the 
dat_provider structure?

hch> 
hch> _______________________________________________
hch> openib-general mailing list
hch> openib-general at openib.org
hch> http://openib.org/mailman/listinfo/openib-general
hch> 
hch> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
hch> 



More information about the general mailing list