[openib-general] [PATCH] kDAPL: cleanup dat/ a bit more

[Itamar Rabenstein]

Hi ,

I am not an expert to pci hot plug but as far as know we currently dont have
away in kdapl
to inform the consumer of kdapl that a provider is going to be unloaded.
pci hot plug should enable any low level driver (openib) to inform high
level driver(kdapl)
that the devide is going down.

In openib gen2 this is doen with Ccall back remove_one().

how it is doen in current kdapl ? 
how the consumer who opened IA will know that this card is going down?

Itamar

> -----Original Message-----
> From: Caitlin Bestler [mailto:caitlin.bestler at gmail.com]
> Sent: Thursday, June 02, 2005 7:57 PM
> To: Itamar Rabenstein
> Cc: Christoph Hellwig; Tom Duffy; openib-general at openib.org
> Subject: Re: [openib-general] [PATCH] kDAPL: cleanup dat/ a bit more
> 
> 
> Why is it that you believe that the DAT registry does not support
> plug and play? The interface was most specifically designed
> to allow that.
> 
> When a device is plugged in, the driver is loaded by existing
> OS mechanisms. It can then load the provider code (if needed).
> Whenever the provider module is loaded it registers itself with
> the registry, and it unregisters itself before it is unloaded.
> 
> Keep in mind that loading/unloading DAT Provider is *not*
> synonymous with loading/unloading drivers. In fact I believe
> the intent is to have a single provider that supports multiple
> devices. Such a provider would simply register itself when
> it was loaded.
> 
> I could see adding new interfaces to track which devices
> are loaded/unloaded for use *by* the DAT provider, but
> I do not see how that changes the function of the DAT
> registry, which is to support multiple DAT Providers.
> 
> On 6/1/05, Itamar Rabenstein <itamar at mellanox.co.il> wrote:
> > I think that if we want to support pci hot plug we need to 
> change the kdapl
> > IF
> > to be like something like the gen2 IF.
> > a link lins of the providers with register/unregister 
> client functions
> > which will register a CB function.
> > we only need to have 4 functions
> > register_client , unregister_client register_provider , 
> unregister_provider
> > 
> >   Itamar
> > 
> > > -----Original Message-----
> > > From: Christoph Hellwig [mailto:hch at lst.de]
> > > Sent: Wednesday, June 01, 2005 9:36 PM
> > > To: Tom Duffy
> > > Cc: openib-general at openib.org
> > > Subject: Re: [openib-general] [PATCH] kDAPL: cleanup dat/ 
> a bit more
> > >
> > >
> > > On Wed, Jun 01, 2005 at 11:23:44AM -0700, Tom Duffy wrote:
> > > > This patch cleans up dat/ a bit, removing unneeded parenthesis,
> > > > gratuitous comments, and a few whitespace cleanups.  
> Please apply.
> > >
> > > btw, I think most of the code under dat/ should just go away ASAP.
> > > Just have a simple linked list of providers with trivial
> > > registration/unregisteration/find_get/put functions like 
> all the other
> > > subsystems and kill all the dictionaty mess and provider vs
> > > provider_info braindamage.
> > >
> > > _______________________________________________
> > > openib-general mailing list
> > > openib-general at openib.org
> > > http://openib.org/mailman/listinfo/openib-general
> > >
> > > To unsubscribe, please visit
> > > http://openib.org/mailman/listinfo/openib-general
> > >
> > _______________________________________________
> > openib-general mailing list
> > openib-general at openib.org
> > http://openib.org/mailman/listinfo/openib-general
> > 
> > To unsubscribe, please visit 
> http://openib.org/mailman/listinfo/openib-general
> >
>