[openib-general] [PATCH] kdapltest: fix pointer to pointer bug

Tom Duffy tduffy at sun.com
Thu Jun 2 19:20:23 PDT 2005


In my work going through trying to get rid of the opaque dat handles, I
came across what looks like a bug in kdapltest.  I don't think
DT_Performance_Test_Create() and DT_Performance_Test_Client() should
take a DAT_IA_HANDLE * as an argument as this would be a pointer to a
pointer.

Of course, the compiler didn't catch it until I changed it to a real
struct pointers thus showing one of the problems with using opaques.

Signed-off-by: Tom Duffy <tduffy at sun.com>

Index: linux-kernel-clean/test/dapltest/test/dapl_performance_util.c
===================================================================
--- linux-kernel-clean/test/dapltest/test/dapl_performance_util.c	(revision 2532)
+++ linux-kernel-clean/test/dapltest/test/dapl_performance_util.c	(working copy)
@@ -33,7 +33,7 @@
 boolean_t
 DT_Performance_Test_Create (
     Per_Test_Data_t 		*pt_ptr,
-    DAT_IA_HANDLE 		*ia_handle,
+    DAT_IA_HANDLE 		ia_handle,
     struct sockaddr *		remote_ia_addr,
     boolean_t 		is_server,
     boolean_t			is_remote_little_endian,
Index: linux-kernel-clean/test/dapltest/test/dapl_performance_client.c
===================================================================
--- linux-kernel-clean/test/dapltest/test/dapl_performance_client.c	(revision 2532)
+++ linux-kernel-clean/test/dapltest/test/dapl_performance_client.c	(working copy)
@@ -34,7 +34,7 @@ int
 DT_Performance_Test_Client (
     Params_t		*params_ptr,
     Per_Test_Data_t 	*pt_ptr,
-    DAT_IA_HANDLE  	*ia_handle,
+    DAT_IA_HANDLE  	ia_handle,
     struct sockaddr *	remote_ia_addr)
 {
     Performance_Test_t 		*test_ptr = NULL;
Index: linux-kernel-clean/test/dapltest/include/dapl_proto.h
===================================================================
--- linux-kernel-clean/test/dapltest/include/dapl_proto.h	(revision 2532)
+++ linux-kernel-clean/test/dapltest/include/dapl_proto.h	(working copy)
@@ -236,7 +236,7 @@ void            DT_Performance_Cmd_Endia
 /* dapl_performance_client.c */
 int             DT_Performance_Test_Client (   Params_t	*params_ptr,
 					       Per_Test_Data_t * pt_ptr,
-					       DAT_IA_HANDLE * ia_handle,
+					       DAT_IA_HANDLE ia_handle,
 					       struct sockaddr *remote);
 
 boolean_t            DT_Performance_Test_Client_Connect (
@@ -261,7 +261,7 @@ boolean_t            DT_Performance_Test
 
 /* dapl_performance_util.c */
 boolean_t            DT_Performance_Test_Create (Per_Test_Data_t * pt_ptr,
-					   DAT_IA_HANDLE * ia_handle,
+					   DAT_IA_HANDLE ia_handle,
 					   struct sockaddr *remote_ia_addr,
 					   boolean_t is_server,
 					   boolean_t is_remote_little_endian,




More information about the general mailing list