[openib-general] [PATCH] kDAPL: remove use of HANDLEs

[Christoph Hellwig]

On Fri, Jun 03, 2005 at 03:32:37PM -0700, Tom Duffy wrote:
> This patch is HUGE.  Sorry.  Not much I could do to split it.
> 
> It makes a superclass for all the dat objects, and subclasses
> dat-provider (dapl) off of it.  No more opaque handles.  No more magic
> checking.  I actually found a few bugs from the compiler because of it
> (more than reported to openib).
> 
> The dapl_header struct is renamed dapl_common.  Most of the _handle
> variables are renamed removing _handle.  It removes the
> get_handle_type() function since this is no longer used.  Also, it
> unimplements [get|set]_consumer_context (for now) since nobody was using
> it.  DAT_BAD_HANDLE() goes as it becomes a simple NULL check.

And event that should go away in most cases.  In the kernel we should't
check for NULL pointers all over the place, if client programmers don't
stick to the APIs they deserve to get panics.