[openib-general] [PATCHv4] kdapl: remove use of HANDLE's (vs. r2572)

[Bernhard Fischer]

On Wed, Jun 08, 2005 at 01:52:47PM -0700, Tom Duffy wrote:
>On Wed, 2005-06-08 at 22:41 +0200, Bernhard Fischer wrote:
>> On Wed, Jun 08, 2005 at 01:19:41PM -0700, Tom Duffy wrote:
>> >On Wed, 2005-06-08 at 21:48 +0200, Bernhard Fischer wrote:
>> 
>> >> 'if (NULL != this)' and 'if (0 != that)' occurances, too? I personally
>> >> would appreciate it, since these variants are harder to read for me.
>> >
>> >What do you want to see instead?
>> >
>> >if (this) {
>> >	/* do stuff */
>> >}
>> 
>> yes, this.
>
>I think James would take these types of patches.
>
>In any event, going through the code with fine toothed comb will happen
>after all the major upheavals, I think.  *I* want to fix all the major
>architectural issues that are holding up acceptance before nit-picking.

certainly.
>
>If I have the time or inclination, I will clean up these things.


-------------- next part --------------
Index: TODO
===================================================================
--- TODO	(revision 2572)
+++ TODO	(working copy)
@@ -23,3 +23,7 @@ IB DAT PROVIDER
 *) cache remote peer's address so that it does not need to be retrieved in 
    dapl_ep_query.
 *) Replace dapl linked lists with Linux linked lists
+*) referencing
+   http://openib.org/pipermail/openib-general/2005-January/003149.html
+   and only then replace the checks turned up by
+   'grep -r -E "NULL.*!=|!=.*NULL" *' with if(foo)... for better readability