[openib-general] Re: [patch][kdapl] enable kdapltest -T P

James Lentini jlentini at netapp.com
Thu Jun 9 08:00:48 PDT 2005


Committed in revision 2574.

On Thu, 2 Jun 2005, Itamar wrote:

itamar> in order to enable kdapltest -T P i needed to remark attr that are not set by openib gen2
itamar> 1) ia_attr.max_evd_qlen
itamar> 2) ia_attr.max_rdma_read_per_ep_in
itamar> 3) ia_attr.max_rdma_read_per_ep_out
itamar> 
itamar> also there was bug in kdapltest memory registration (file dapl_bpool.c)
itamar> and there was bug where we free memory and then we try to print part of the memory
itamar> 
itamar> i can run now kdapltest -T P for both RR and RW
itamar> 
itamar> 
itamar> enable kdapltest -T P
itamar> fix bug in memory registration
itamar> Signed-off-by: Itamar Rabenstein <itamar at mellanox.co.il>
itamar> 
itamar> Index: test/dapl_performance_util.c
itamar> ===================================================================
itamar> --- test/dapl_performance_util.c	(revision 2522)
itamar> +++ test/dapl_performance_util.c	(working copy)
itamar> @@ -76,17 +76,20 @@
itamar>      }
itamar>  
itamar>      pipeline_len = DT_min (
itamar> -	DT_min (test_ptr->cmd->num_iterations,
itamar> -	       test_ptr->cmd->pipeline_len),
itamar> -	DT_min (test_ptr->ia_attr.max_dto_per_ep,
itamar> -	       test_ptr->ia_attr.max_evd_qlen));
itamar> +        DT_min (test_ptr->cmd->num_iterations,
itamar> +                test_ptr->cmd->pipeline_len),
itamar> +        test_ptr->ia_attr.max_dto_per_ep);
itamar> +/*     DT_min (test_ptr->ia_attr.max_dto_per_ep, */
itamar> +/*            test_ptr->ia_attr.max_evd_qlen)    */
itamar> +/*     );                                        */
itamar>  
itamar>      if ( RDMA_READ == test_ptr->cmd->op.transfer_type )
itamar> -    {
itamar> -	pipeline_len = DT_min (pipeline_len, 
itamar> -                               test_ptr->ia_attr.max_rdma_read_per_ep_in);
itamar> -        pipeline_len = DT_min (pipeline_len, 
itamar> -                               test_ptr->ia_attr.max_rdma_read_per_ep_out);
itamar> +    {   
itamar> +/*         max_rdma_read_per_ep_in max_rdma_read_per_ep_out are not set by gen2 */
itamar> +/*         pipeline_len = DT_min (pipeline_len,                                 */
itamar> +/*                                test_ptr->ia_attr.max_rdma_read_per_ep_in);   */
itamar> +/*         pipeline_len = DT_min (pipeline_len,                                 */
itamar> +/*                                test_ptr->ia_attr.max_rdma_read_per_ep_out);  */
itamar>      }
itamar>      
itamar>      test_ptr->reqt_evd_length = pipeline_len;
itamar> @@ -203,7 +206,7 @@
itamar>  					    DAT_HANDLE_NULL, /* rmr */
itamar>  					    DT_PERF_SYNC_BUFF_SIZE,
itamar>  					    2, /* 2 RMIs */
itamar> -					    255, /* FIXME should query for this */
itamar> +					    256, /* FIXME should query for this */
itamar>  					    FALSE,
itamar>  					    FALSE);
itamar>      if ( !test_ptr->ep_context.bp )
itamar> @@ -406,8 +409,8 @@
itamar>  	}
itamar>      }
itamar>  
itamar> +    DT_Tdep_PT_Debug (1, (phead,"Test[" F64x "]: cleanup is done\n", test_ptr->base_port));
itamar>      DT_MemListFree (test_ptr->pt_ptr, test_ptr);
itamar> -    DT_Tdep_PT_Debug (1, (phead,"Test[" F64x "]: cleanup is done\n", test_ptr->base_port));
itamar>  
itamar>      return status;
itamar>  }
itamar> Index: test/dapl_bpool.c
itamar> ===================================================================
itamar> --- test/dapl_bpool.c	(revision 2522)
itamar> +++ test/dapl_bpool.c	(working copy)
itamar> @@ -388,7 +388,7 @@
itamar>  u64
itamar>  DT_Bpool_GetRegBuff (Bpool * bpool_ptr, int index)
itamar>  {
itamar> -    return ( bpool_ptr->reg_addr + index * bpool_ptr->seg_size );
itamar> +    return (virt_to_phys(DT_Bpool_GetBuffer(bpool_ptr,index)));
itamar>  }
itamar>  
itamar>  /*****************************************************************************/
itamar> -- 
itamar> Itamar
itamar> 



More information about the general mailing list