[openib-general] Re: [PATCH] [TRIVIAL] [kdapl] CM: Message and commentary changes

[James Lentini]

Committed in revision 2578.

On Thu, 9 Jun 2005, Hal Rosenstock wrote:

halr> Message and commentary changes to make consistent with ongoing code
halr> changes
halr> 
halr> Signed-off-by: Hal Rosenstock <halr at voltaire.com>
halr> 
halr> Index: dapl_openib_cm.c
halr> ===================================================================
halr> --- dapl_openib_cm.c	(revision 2577)
halr> +++ dapl_openib_cm.c	(working copy)
halr> @@ -81,8 +81,7 @@
halr>  	int status;
halr>  
halr>  	if (conn->ep->qp == NULL) {
halr> -		dapl_dbg_log(DAPL_DBG_TYPE_ERR, " dapl_rep_recv: invalid qp "
halr> -			     "handle\n");
halr> +		dapl_dbg_log(DAPL_DBG_TYPE_ERR, " dapl_rep_recv: invalid qp\n");
halr>  		goto disc;
halr>  	}
halr>  
halr> @@ -416,6 +415,7 @@
halr>   *        ep
halr>   *        remote_ia_address
halr>   *        remote_conn_qual
halr> + *        timeout
halr>   *        private_data_size    size of private data and structure
halr>   *        private_data         pointats_entry->semer to private data structure
halr>   *
halr> @@ -440,7 +440,7 @@
halr>  
halr>  	ep_ptr = (struct dapl_ep *)ep;
halr>  	if (ep_ptr->qp == NULL) {
halr> -		printk(KERN_ERR "dapl_ib_connect: qp handle invalid\n");
halr> +		printk(KERN_ERR "dapl_ib_connect: qp invalid\n");
halr>  		return DAT_INTERNAL_ERROR;
halr>  	}
halr>  
halr> @@ -550,7 +550,7 @@
halr>   * after the final disconnect callback has occurred.
halr>   *
halr>   * Input:
halr> - *      ep_ptr          struct dapl_ep
halr> + *      ep_ptr          pointer to dapl_ep struct
halr>   *      active          Indicates active side of connection
halr>   *
halr>   * Output:
halr> @@ -581,7 +581,7 @@
halr>  					"on transition to error\n", status);
halr>  	} else
halr>  		dapl_dbg_log(DAPL_DBG_TYPE_ERR, "dapl_ib_disconnect_clean: "
halr> -						"invalid qp handle\n");
halr> +						"invalid qp\n");
halr>  }
halr>  
halr>  /*
halr> @@ -590,7 +590,7 @@
halr>   * Move the QP to INIT state again.
halr>   *
halr>   * Input:
halr> - *      ep_ptr          DAPL_EP
halr> + *      ep_ptr          pointer to dapl_ep struct
halr>   *
halr>   * Output:
halr>   *      none
halr> @@ -641,8 +641,8 @@
halr>   * Have the CM set up a connection listener.
halr>   *
halr>   * Input:
halr> - *        ib_hca_handle            HCA handle
halr> - *        qp_handle                QP handle
halr> + *        ia_ptr                   pointer to dapl_ia struct
halr> + *        sp_ptr                   pointer to dapl_sp struct
halr>   *
halr>   * Output:
halr>   *         none
halr> @@ -685,8 +685,8 @@
halr>   * Have the CM remove a connection listener.
halr>   *
halr>   * Input:
halr> - *      ia               IA handle
halr> - *      ServiceID               IB Channel Service ID
halr> + *      ia_ptr                  pointer to dapl_ia struct
halr> + *      sp_ptr                  pointer to dapl_sp struct
halr>   *
halr>   * Output:
halr>   *      none
halr> @@ -719,7 +719,7 @@
halr>   * Perform necessary steps to reject a connection
halr>   *
halr>   * Input:
halr> - *        cm
halr> + *      cm                      pointer to dapl_cm_id struct
halr>   *
halr>   * Output:
halr>   *         none
halr> @@ -863,7 +863,7 @@
halr>   *
halr>   * Input:
halr>   *	cr
halr> - *	private data structure handle (only if not using ATS)
halr> + *	private data structure pointer (only if not using ATS)
halr>   *
halr>   * Output:
halr>   *	remote_ia_address: where to place the remote address
halr> 
halr> 
halr>