[openib-general] [PATCH 8/9] kDAPL: convert the hcas ia list to linux native

[Tom Duffy]

On Tue, 2005-06-14 at 16:21 -0400, James Lentini wrote:
> 
> On Mon, 13 Jun 2005, Tom Duffy wrote:
> 
> tduffy> diff -Nurp -X /home/tduffy/dontdiff linux-kernel-ll8/dat-provider/dapl_ia.c linux-kernel-ll9/dat-provider/dapl_ia.c
> tduffy> --- linux-kernel-ll8/dat-provider/dapl_ia.c	2005-06-13 16:50:30.624000000 -0700
> tduffy> +++ linux-kernel-ll9/dat-provider/dapl_ia.c	2005-06-13 16:56:10.004000000 -0700
> tduffy> @@ -62,7 +62,6 @@ struct dapl_ia *dapl_ia_alloc(struct dat
> tduffy>  	ia->hca = hca;
> tduffy>  	ia->async_error_evd = NULL;
> tduffy>  	ia->cleanup_async_error_evd = FALSE;
> tduffy> -	dapl_llist_init_entry(&ia->hca_ia_list_entry);
> 
> Shouldn't we replace this line with an INIT_LIST_HEAD(&ia->list)? Or 
> is this going to be done in the next patch?

This isn't the head.  It is the entry.  Therefore, it doesn't need to be
initialized.

-tduffy

-- 
I wish we lived in the America of yesteryear that only exists in the
minds of us Republicans.
                                        -- Ned Flanders
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050614/157c9f6f/attachment.sig>