[openib-general] Re: [PATCH] sdp_post_rdma_iocb_snk check iocb

[Libor Michalek]

On Wed, Jun 15, 2005 at 11:01:19PM +0300, Michael S. Tsirkin wrote:
> Quoting r. Libor Michalek <libor at topspin.com>:
> > Subject: Re: [PATCH] sdp_post_rdma_iocb_snk check iocb
> > 
> > On Wed, Jun 15, 2005 at 12:44:08PM +0300, Michael S. Tsirkin wrote:
> > > In sdp_post_rdma_iocb_snk, if sdp_iocb_q_get_head returns NULL, iocb
> > > is then used without checking.
> > 
> >   This is done in a number of places, and the check for NULL iocb should
> > not be necessary. Earlier in each function where it's done, we perform a
> > look at the head of the queue and only continue if there is an iocb at
> > the head of the queue:
> > 
> > 	iocb = sdp_iocb_q_look(&conn->r_pend);
> > 
> >   The reason I did it this way is to avoid having to return the iocb back
> > into the same queue if it is not entirely consumed or on a recoverable
> > error, depending on the function. 
> 
> Okay, but the test if (result < 0)  is clearly bogus since result
> isnt set?

  Yes, that's true. In the patch I sent out yesterday and committed today
that is resolved.

-Libor