[openib-general] Re: [PATCH][kdapl]update dat_rmr_bind API & delete dapl_hash

[Itamar & Shira Rabenstein]

>Itamar,
>
>Can you seperate the RMR api change and hash table removal into a 
>seperate patch?

I dont see why, the new input param to dat_rmr_bind (lmr_handle) come
in order that we will be able to remove the hash table so this is one
patch.

>Merging the HCA and IA code into the dapl_ia.[ch] files doesn't feel 
>right to me. I think of the HCA as a DAT object just like IAs, EPs, 
>LMRs, etc, and hence it should have its own file.
>
>james


There are 4 function in this files:

2 were merged to provider code:
      dapl_hca_alloc(13 lines) :which i think is part of the provider code .
      dapl_hca_free (1 line) == kfree , no need a function for this.
2 were merged to ia code:
      dapl_hca_link_ia (3 lines )     : no need a function to call list add
      dapl_hca_unlink_ia(3 lines)    : no need a function to call list_del

I belive that we need to make the code more readable and to have this functions
is not a good idea and to add 2 files for this is for sure a bad idea ...

So Please commit as is.

 Itamar 


>On Wed, 15 Jun 2005, Rabenstein Itamar wrote:
>
>> Updated dat_rmr_bind API (added lmr_handle as input param)
>> delete dapl_hash.[h|c] files (not needed any more)
>> Integrate dapl_hca_util functions in ia/provider code
>> delete dapl_hca_util.[h|c] files
>>
>>Signed-off-by: Itamar Rabenstein <itamar at mellanox.co.il>
>>