[openib-general] Re: [PATCHv7] SDP: make SDP buildable on 2.6.12-final

[Tom Duffy]

On Mon, 2005-06-20 at 11:28 -0700, Libor Michalek wrote:
> Looks good, but I do have one question, why did you move the clearing
> of 'struct sock' from 'struct socket' to the end of the function?
> Specifically if we are waiting on linger during the release I don't
> think we want sock to have an sk, this avoids having any other user
> system calls on this socket. This is done the same way in af_inet.c, 
> the clear comes before the close/linger...

I moved it recently, earlier versions of the patch didn't do that.  You
can move it back if needed.  I was trying to trace down a close bug, and
this did not fix it.  So, final answer is: keep it the way it was.

-tduffy
-- 
I wish we lived in the America of yesteryear that only exists in the
minds of us Republicans.
                                        -- Ned Flanders
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050620/b40b016a/attachment.sig>