[openib-general] Re: [PATCH] kDAPL: remove dapl_os_assert()

James Lentini jlentini at netapp.com
Thu Jun 23 14:43:22 PDT 2005


Gotcha. I missed that.

On Thu, 23 Jun 2005, Tom Duffy wrote:

> On Thu, 2005-06-23 at 16:55 -0400, James Lentini wrote:
>> Why did you remove the asserts in dapl_ib_post_recv() and
>> dapl_ib_post_send()?
>
> The code continues 6 lines down:
>
> < assert if cookie is null here >
>
>        sg_list = ep->recv_iov;
>        for (i = 0; i < num_segments; i++, sg_list++) {
>                sg_list->addr = local_iov[i].virtual_address;
>                sg_list->length = (u32) local_iov[i].segment_length;
>                sg_list->lkey = local_iov[i].lmr_context;
>                total_len += sg_list->length;
>        }
>        cookie->val.dto.size = total_len;
> 	^^^^^^^^
> 		would crash here anyways.
>
> -tduffy
>



More information about the general mailing list