[openib-general] SDP sk_data_ready() callback

[Arne Redlich]

Am Dienstag, den 28.06.2005, 15:32 -0700 schrieb Libor Michalek:
> On Tue, Jun 28, 2005 at 09:15:21AM +0200, Arne Redlich wrote:
> > Am Montag, den 27.06.2005, 11:35 -0700 schrieb Libor Michalek:
> > > On Wed, Jun 22, 2005 at 10:39:43AM +0200, Arne Redlich wrote:
> > > > Hi,
> > > > 
> > > > I'm trying to use SDP from within the kernel. My problem is that the
> > > > code relies on sk_data_ready() (this callback is modified to wake up a
> > > > Rx thread before executing the original function), but sk_data_ready()
> > > > apparently never gets called. Is there any way to fix this?
> > > 
> > >   You mean that you replace sk->sk_data_ready, with a similar but
> > > slightly modified version and so rely on sk->sk_data_ready() being
> > > called?
> > 
> > Yes, that's right. Actually the modifications are just minor as I
> > already pointed out: the replacement function just wakes the thread and
> > then calls the original sk_data_ready().
> > 
> > >   You're right it's currently not being called, instead we're calling
> > > the function to which it's pointing directly, and for no real reason.
> > > Also, the function that's being called is a duplicate of the function
> > > sock_def_readable() in net/sock.c. I'll look at correcting these
> > > issues.
> 
>   Here's a patch which uses the socket readiness function pointers,
> as well as using the default readiness functions. Except for write
> readiness, (sk->sk_write_space) which currently uses different info
> to determine write space.
> 
> -Libor

Thanks a lot, it's working now as expected.

Arne
-- 
Arne Redlich
Xiranet Communications GmbH