[openib-general] [PATCH][SDP] lnx_stream_ops should be declared static
Tom Duffy
tduffy at sun.com
Tue Mar 1 09:56:09 PST 2005
lnx_stream_ops should be static. Also, fix one more static name in
sdp_proc.c
Signed-off-by: Tom Duffy <tduffy at sun.com>
Index: drivers/infiniband/ulp/sdp/sdp_inet.c
===================================================================
--- drivers/infiniband/ulp/sdp/sdp_inet.c (revision 1932)
+++ drivers/infiniband/ulp/sdp/sdp_inet.c (working copy)
@@ -1373,7 +1373,7 @@ static int sdp_inet_shutdown(struct sock
/*
* Primary socket initialization
*/
-struct proto_ops _lnx_stream_ops = {
+static struct proto_ops lnx_stream_ops = {
.family = AF_INET_SDP,
.release = sdp_inet_release,
.bind = sdp_inet_bind,
@@ -1419,7 +1419,7 @@ static int sdp_inet_create(struct socket
return -ENOMEM;
}
- sock->ops = &_lnx_stream_ops;
+ sock->ops = &lnx_stream_ops;
sock->state = SS_UNCONNECTED;
sock_graft(conn->sk, sock);
Index: drivers/infiniband/ulp/sdp/sdp_proc.c
===================================================================
--- drivers/infiniband/ulp/sdp/sdp_proc.c (revision 1932)
+++ drivers/infiniband/ulp/sdp/sdp_proc.c (working copy)
@@ -81,7 +81,7 @@ static int sdp_proc_read_parse(char *pag
* (anything that is not a module) should create an entry and define read
* write function.
*/
-static struct sdpc_proc_ent _file_entry_list[SDP_PROC_ENTRIES] = {
+static struct sdpc_proc_ent file_entry_list[SDP_PROC_ENTRIES] = {
{
.entry = NULL,
.type = SDP_PROC_ENTRY_MAIN_BUFF,
@@ -136,7 +136,7 @@ int sdp_main_proc_cleanup(void)
* first clean-up the frameworks tables
*/
for (counter = 0; counter < SDP_PROC_ENTRIES; counter++) {
- sub_entry = &_file_entry_list[counter];
+ sub_entry = &file_entry_list[counter];
if (sub_entry->entry) {
remove_proc_entry(sub_entry->name, dir_root);
sub_entry->entry = NULL;
@@ -189,7 +189,7 @@ int sdp_main_proc_init(void)
dir_root->owner = THIS_MODULE;
for (counter = 0; counter < SDP_PROC_ENTRIES; counter++) {
- sub_entry = &_file_entry_list[counter];
+ sub_entry = &file_entry_list[counter];
if (sub_entry->type != counter) {
result = -EFAULT;
goto error;
More information about the general
mailing list