[openib-general] PATCH] [TRIVIAL] SDP: sdp_pass.c remove redundant initialization

Hal Rosenstock halr at voltaire.com
Wed Mar 9 07:25:57 PST 2005


SDP: sdp_pass.c remove redundant initialization
(Similar to previous sdp_actv.c patch)

qp_attr->min_rnr_timer is already initialized to 0 by
cm_init_qp_rtr_attr in cm.c

Is this really intended to be IB_RNR_TIMER_122_88 instead ?

Signed-off-by: Hal Rosenstock <halr at voltaire.com>

Index: sdp_pass.c
===================================================================
--- sdp_pass.c	(revision 1970)
+++ sdp_pass.c	(working copy)
@@ -235,10 +235,9 @@
 		goto error;
 	}
 
-	qp_attr->min_rnr_timer = 0; /* IB_RNR_TIMER_122_88; */
 	qp_attr->rq_psn        = conn->rq_psn;
 
-        qp_mask |= (IB_QP_MIN_RNR_TIMER | IB_QP_RQ_PSN);
+        qp_mask |= IB_QP_RQ_PSN;
 
         result = ib_modify_qp(conn->qp, qp_attr, qp_mask);
 	kfree(qp_attr);






More information about the general mailing list