[openib-general] Re: [PATCH] agent: Add IB ping server agent

[Michael S. Tsirkin]

Quoting r. Hal Rosenstock <halr at voltaire.com>:
> Subject: Re: [PATCH] agent: Add IB ping server agent
> 
> On Thu, 2005-03-17 at 12:38, Sean Hefty wrote:
> > Roland Dreier wrote:
> > > I would suggest moving the ping server at least into its own source
> > > file, if not into its own module.  I'm not convinced that we want to
> > > have a vendor-specific MAD handler unconditionally compiled into the
> > > core MAD support.
> > 
> > I agree with this.  This feels like it should be a separate module.
> 
> OK but this will result in some code duplication. I should have this
> later today and will revert back the changes to agent.c and agent_priv.h
> of earlier today.
> 
> -- Hal

I think a compile option is simpler, and would be sufficient.

-- 
MST - Michael S. Tsirkin