[openib-general] Re: [PATCH][DAPL] fix kdapltest Makefile

[James Lentini]

Tom,

Do you also want to remove the first EXTRA_CLAGS value:

       -Idrivers/dat             \

or did you leave that there on purpose?

You shouldn't need the

       -I$(src)/../../../dat-provider           \

line. DAT consumers only need to be aware of the registry (the code in 
the dat directory).

james

On Mon, 2 May 2005, Tom Duffy wrote:

> This fixes the problem of building kdapltest on x86_64.  It also makes
> it build outside of a kernel without dat installed.
>
> Also, if I want verbose, I will specify verbose; please don't do it for
> me.
>
> Signed-off-by: Tom Duffy <tduffy at sun.com>
>
> Index: gen2/users/jlentini/linux-kernel/test/dapltest/kdapl/Makefile
> ===================================================================
> --- gen2/users/jlentini/linux-kernel/test/dapltest/kdapl/Makefile	(revision 2247)
> +++ gen2/users/jlentini/linux-kernel/test/dapltest/kdapl/Makefile	(working copy)
> @@ -37,7 +37,7 @@
> ifeq ($(origin KERNELRELEASE), undefined)
>
> KDAPLTEST_ROOT  = `pwd` # directory that contains this makefile
> -KERNEL_ROOT     = /lib/modules/`uname -r`/build # root of kernel sources
> +KERNEL_ROOT     ?= /lib/modules/`uname -r`/build # root of kernel sources
>
> # Tools
> ECHO            = /bin/echo
> @@ -45,7 +45,7 @@ RM              = /bin/rm
>
> all :
> 	@$(ECHO) "--- Compiling kdapltest module ---"
> -	$(MAKE) -C $(KERNEL_ROOT) M=$(KDAPLTEST_ROOT) V=1 modules
> +	$(MAKE) -C $(KERNEL_ROOT) M=$(KDAPLTEST_ROOT) modules
>
> clean :
> 	$(RM) -rf \
> @@ -67,6 +67,9 @@ ifeq (${IS_i686},i686)
> # Override -msoft-float in arch/i386/Makefile
> EXTRA_CFLAGS += -mhard-float
> endif
> +ifeq (${IS_i686},x86_64)
> +EXTRA_CFLAGS += -msse
> +endif
>
> EXTRA_CFLAGS += \
>     -Idrivers/dat		\
> @@ -74,7 +77,9 @@ EXTRA_CFLAGS += \
>     -I$(src)/../mdep/linux 	\
>     -I$(src)/../kdapl          	\
>     -I$(src)/../common 		\
> -    -I$(src)/../test
> +    -I$(src)/../test 		\
> +    -I$(src)/../../../dat-provider 		\
> +    -I$(src)/../../../dat
>
> EXTRA_CFLAGS += \
>     -D__KDAPL__ 	\
>