[openib-general] [PATCH] [RMPP] ib_coalesce_recv_mad

Roland Dreier roland at topspin.com
Tue May 3 17:11:05 PDT 2005


I'm not sure I like this "usermode" parameter that selects between
memcpy() and copy_to_user().  For one thing, it means that it is
impossible to fix the sparse warnings without defeating the sparse
address space testing: you have to add a casts to and from __user
pointers all over the place.

Also, it seems that there's only one caller that's ever going to use
the usermode parameter, namely user_mad.c.

Unfortunately I don't see a good way to avoid duplicating the (simple)
logic in ib_coalesce_recv_mad().

 - R.



More information about the general mailing list