[openib-general] Re: RMPP

Hal Rosenstock halr at voltaire.com
Wed May 4 16:12:49 PDT 2005


On Wed, 2005-05-04 at 17:51, Sean Hefty wrote: 
> Can you try with this patch?
> 
> Signed-off-by: Sean Hefty <sean.hefty at intel.com>
> 
> Index: core/mad.c
> ===================================================================
> -- core/mad.c	(revision 2256)
> +++ core/mad.c	(working copy)
> @@ -796,9 +796,9 @@
>  	buf = kmalloc(sizeof *send_buf + buf_size, gfp_mask);
>  	if (!buf)
>  		return ERR_PTR(-ENOMEM);
> +	memset(buf, 0, sizeof *send_buf + buf_size);
>  
>  	send_buf = buf + buf_size;
> -	memset(send_buf, 0, sizeof *send_buf);
>  	send_buf->mad = buf;
>  
>  	send_buf->sge.addr = dma_map_single(mad_agent->device->dma_device,

Yes, that looks better in terms of clearing the padding. I still need to
double check my math on the PayloadLengths.

Thanks.

-- Hal




More information about the general mailing list