[openib-general] Re: [openib-commits] r2260 - in gen2/trunk/src/linux-kernel/infiniband: core include

[Tom Duffy]

On Thu, 2005-05-05 at 10:46 -0700, sean.hefty at openib.org wrote:
> Modified:
>    gen2/trunk/src/linux-kernel/infiniband/core/mad.c
>    gen2/trunk/src/linux-kernel/infiniband/include/ib_mad.h
> Log:
> Add formatting of RMPP header to ib_create_send_mad.  Clear
> allocated MAD data buffer.

You probably already know this, but this checkin breaks the build:

  CC [M]  drivers/infiniband/core/ping.o
/build1/tduffy/openib-work/linux-2.6.12-rc3-openib/drivers/infiniband/core/ping.c: In function ‘pingd_recv_handler’:
/build1/tduffy/openib-work/linux-2.6.12-rc3-openib/drivers/infiniband/core/ping.c:131: error: too few arguments to function ‘ib_create_send_mad’
make[4]: *** [drivers/infiniband/core/ping.o] Error 1
make[3]: *** [drivers/infiniband/core] Error 2
make[2]: *** [drivers/infiniband] Error 2
make[1]: *** [drivers] Error 2
make: *** [_all] Error 2

This patch fixes the build assuming ping does not need rmpp.

Signed-off-by: Tom Duffy <tduffy at sun.com>

Index: drivers/infiniband/core/ping.c
===================================================================
--- drivers/infiniband/core/ping.c	(revision 2262)
+++ drivers/infiniband/core/ping.c	(working copy)
@@ -124,7 +124,7 @@ static void pingd_recv_handler(struct ib
 	}
 
 	msg = ib_create_send_mad(mad_agent, mad_recv_wc->wc->src_qp,
-				 mad_recv_wc->wc->pkey_index, ah,
+				 mad_recv_wc->wc->pkey_index, ah, 0,
 				 offsetof(struct ib_vendor_mad, data),
 				 mad_recv_wc->mad_len -
 					offsetof(struct ib_vendor_mad, data),