[openib-general] [PATCH] [MAD] changes to ib_create_send_mad

Hal Rosenstock halr at voltaire.com
Thu May 5 14:04:14 PDT 2005


On Thu, 2005-05-05 at 14:53, Hal Rosenstock wrote:
> > The payload values in both cases are correct.
> 
> Let me look again. I don't think I was hallucinating...

I wasn't hallucinating. Just stupid code. I stepped on this field
without noticing. Sorry for pointing in the wrong direction.

But one point which perhaps can be improved:

With rmpp_active, ib_create_send_mad formats certain MAD fields. This is
before some copy occurs. So somehow the two need "merging" for the
modified fields. I think it makes a straight copy impossible.

So a separate call could do this after the copy or the header can be
saved, the copy made, and then the header merged. Those are the 2
approaches I have come up with. Not sure I like either of them. I'm open
to better ideas :-)

-- Hal




More information about the general mailing list