[openib-general] [patch] misc trivia nitpicks 04

Grant Grundler iod00d at hp.com
Fri May 6 14:08:07 PDT 2005


On Fri, May 06, 2005 at 10:25:51PM +0200, Bernhard Fischer wrote:
> I've also inlined double_compar

Eh? That's pointless.
The double_compar() function pointer is passed to qsort():
	        qsort(delta, iters - 1, sizeof *delta, double_compar);

> and inserted an else befor the second if to have a better
> if elif else chain. Cosmetic since it's fed into qsort, i assume.

I ditched the "else" in "else return 0". Pointless too.
(This is inside double_compar()).

> Even the original version just segfaults on me.
> I must be missing something..Still looking

Hrm...can you post output how far it gets?

You verified your libibverbs matches your kernel modules?

thanks,
grant



More information about the general mailing list