[openib-general] [patch] misc trivia nitpicks 03

[Libor Michalek]

On Thu, May 05, 2005 at 09:26:14PM +0200, Bernhard Fischer wrote:
> Hi,
> 
> What's the status of SDP_EXPECT ?
> will it be submitted upstream or cleaned up beforehand? Just curious.

   It should be cleaned up before hand. Each one needs to be looked at,
and either the return value should be used, with the error passed down
the call stack, or the function should be a void return.

> - fold sdp_conn_internal_lock into sdp_conn_lock.
> - fold sdp_conn_internal_unlock into sdp_conn_unlock.
> 
> PS: those folds are completely untested.. Libor, anyone else?
> thank you,

  This was discussed earlier. I wasn't planning on folding internal_lock()
into lock(), since the internal call is only made as an uncommon exception
path when there is lock contention. This is just like lock_sock/release_sock
in net/core/sock.c and include/net/sock.h. I would use those locks, but they
are too closely tied to skb processing, specifically the sk_backlog queue.

-Libor