[openib-general] Re: perftest-03: put C code in .c file

[Michael S. Tsirkin]

Quoting r. Grant Grundler <iod00d at hp.com>:
> Subject: perftest-03: put C code in .c file
> 
> Hi Michael,
> Patch below fixes up the Makefile and getclock.h so C code is in C files
> like people expect.
> 
> Unfortunately, I don't know how to make svn diff treat a new file as
> part of the diff.  "cvs -upN" is how I would do it for cvs.
> svn just (correctly) whines it doesn't know about the new file.
> 
> But it's easy to generate get_clock.c:
> 	cp get_clock.h get_clock.c
> 	edit get_clock.c and delete everything related to get_cycles().
> 	(This preserves the copyright/license too)
> 
> *THEN* apply the patch below.
> 
> thanks,
> grant
> 

You have to svn add before svn diff -x --diff-cmd=/usr/bin/diff -x -upN
Grant, could you please resend, while also adding a Signed-off-by line?

Quoting linux kernel's Documentation/SubmittingPatches:

The sign-off is a simple line at the end of the explanation for the
patch, which certifies that you wrote it or otherwise have the right to
pass it on as a open-source patch.  The rules are pretty simple: if you
can certify the below:

        Developer's Certificate of Origin 1.0

        By making a contribution to this project, I certify that:

        (a) The contribution was created in whole or in part by me and I
            have the right to submit it under the open source license
            indicated in the file; or

        (b) The contribution is based upon previous work that, to the best
            of my knowledge, is covered under an appropriate open source
            license and I have the right under that license to submit that
            work with modifications, whether created in whole or in part
            by me, under the same open source license (unless I am
            permitted to submit under a different license), as indicated
            in the file; or

        (c) The contribution was provided directly to me by some other
            person who certified (a), (b) or (c) and I have not modified
            it.

then you just add a line saying

        Signed-off-by: Random J Developer <random at developer.org>




-- 
MST - Michael S. Tsirkin