[openib-general] Re: [PATCHv2] kDAPL: remove DAT_RETURN

[Caitlin Bestler]

DAT_RETURN serves two distinct purposes: it is an immediate return
to a kernel specific caller, and it is a standardized error encoding for
clients outside of the linux kernel (loadable modules and or proxied
user consumers).

Even if the functional return to in-kernel clients is converted to comply
with kernel coding conventions, the information currently encoded
in the DAT_RETURN needs to be deliverable to DAPL clients that
are outside of the linux kernel.

Therefore the current enums need to be retained, and there should
be some mechanism for these precise diagnostics to be relayed
to non-kernel clients. An external shim cannot do this *after*
the information is lost by using a standard error return. (I am
assuming that creating a list of error returns that encompass
everything that DAT_RETURN *Can* encode is out of the
question, there's a reason it's multi-layer now).

One possibility would be to add an external_client_dat_return *
out parameter that would allow a shim to restore the full
DAT defined error code for non-kernel clients.



On 5/12/05, Tom Duffy <tduffy at sun.com> wrote:
> On Thu, 2005-05-12 at 11:50 -0400, James Lentini wrote:
> > Thanks for the updated patch Tom. It is committed in revision 2316.
> >
> > Eventually we will need to remove our dat_return_* enums and replace
> > our return values with errno values. Correct?
> 
> That is right.  This is just a first pass at cleaning it up.
> 
> -tduffy
> 
> 
> BodyID:10548341.2.n.logpart (stored separately)
> 
> _______________________________________________
> openib-general mailing list
> openib-general at openib.org
> http://openib.org/mailman/listinfo/openib-general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
> 
>