[openib-general] Re: [PATCH] kDAPL: change EXPORT_SYMBOL to EXPORT_SYMBOL_GPL

[James Lentini]

Tom,

I think we should follow the example of other parts of the kernel and 
export our symbols without qualifications. This would keep our driver 
interface in synch with similar subsystems.

james

On Fri, 13 May 2005, Tom Duffy wrote:

tduffy> On Fri, 2005-05-13 at 11:52 -0700, Caitlin Bestler wrote:
tduffy> > What about kernel clients that are compiled separately from the kernel
tduffy> > that want to be OS neutral and use kdat.h as published by the DAT
tduffy> > Collaborative?
tduffy> 
tduffy> Make sure this doesn't happen.
tduffy> 
tduffy> Signed-off-by: Tom Duffy <tduffy at sun.com>
tduffy> 
tduffy> Index: linux-kernel-gpl/dat/api.c
tduffy> ===================================================================
tduffy> --- linux-kernel-gpl/dat/api.c	(revision 2338)
tduffy> +++ linux-kernel-gpl/dat/api.c	(working copy)
tduffy> @@ -619,7 +619,7 @@ u32 dat_ia_openv(const char *name, int a
tduffy>              name, async_event_qlen, async_event_handle, ia_handle);
tduffy>  }
tduffy>  
tduffy> -EXPORT_SYMBOL(dat_ia_openv);
tduffy> +EXPORT_SYMBOL_GPL(dat_ia_openv);
tduffy>  
tduffy>  /***********************************************************************
tduffy>   * Function: dat_ia_close
tduffy> @@ -673,7 +673,7 @@ u32 dat_ia_close(DAT_IA_HANDLE ia_handle
tduffy>  	return status;
tduffy>  }
tduffy>  
tduffy> -EXPORT_SYMBOL(dat_ia_close);
tduffy> +EXPORT_SYMBOL_GPL(dat_ia_close);
tduffy>  
tduffy>  /***********************************************************************
tduffy>   * Function: dat_strerror
tduffy> @@ -706,7 +706,7 @@ u32 dat_strerror(u32 value, const char *
tduffy>  	return DAT_SUCCESS;
tduffy>  }
tduffy>  
tduffy> -EXPORT_SYMBOL(dat_strerror);
tduffy> +EXPORT_SYMBOL_GPL(dat_strerror);
tduffy>  
tduffy>  /***********************************************************************
tduffy>   * Function: dat_registry_add_provider
tduffy> @@ -731,7 +731,7 @@ u32 dat_registry_add_provider(const stru
tduffy>  	return dat_dr_insert(provider_info, provider->ia_open_func);
tduffy>  }
tduffy>  
tduffy> -EXPORT_SYMBOL(dat_registry_remove_provider);
tduffy> +EXPORT_SYMBOL_GPL(dat_registry_remove_provider);
tduffy>  
tduffy>  /***********************************************************************
tduffy>   * Function: dat_registry_remove_provider
tduffy> @@ -750,7 +750,7 @@ u32 dat_registry_remove_provider(const s
tduffy>  	return dat_dr_remove(provider_info);
tduffy>  }
tduffy>  
tduffy> -EXPORT_SYMBOL(dat_registry_add_provider);
tduffy> +EXPORT_SYMBOL_GPL(dat_registry_add_provider);
tduffy>  
tduffy>  /***********************************************************************
tduffy>   *  Function: dat_registry_list_providers
tduffy> @@ -787,4 +787,4 @@ u32 dat_registry_list_providers(int max_
tduffy>  	return status;
tduffy>  }
tduffy>  
tduffy> -EXPORT_SYMBOL(dat_registry_list_providers);
tduffy> +EXPORT_SYMBOL_GPL(dat_registry_list_providers);
tduffy>