[openib-general] Re: [openib-commits] r2426 - gen2/users/jlentini/linux-kernel/dat-provider

[Tom Duffy]

On Sat, 2005-05-21 at 01:56 +0200, Bernhard Fischer wrote:
> sun will hopefuly fix all of

-enoparse hopefuly s/hopefuly/hopefully/ ;-)

> egrep -ri "(^[[:space:]]*\(void\))"

As we discussed earlier, it is not wrong to cast the return to (void) if
indeed you are ignoring a non-void return.  If, in fact, the function
returns void, then casting is dumb.  Also, if the function doesn't
return anything useful and you always disregard the return, the function
should be changes to return void.

> openib.gen2/upstream/gen2/trunk/|egrep -v "svn-(text|base)"
> so i won't comment on that single occurance above ;)

-enoparse occurance s/occurance/occurrence/

Later,

sun
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050520/60a1a9df/attachment.sig>