[openib-general] [PATCH] kDAPL: cleanup some C++ style comments

Tom Duffy tduffy at sun.com
Mon May 23 22:25:49 PDT 2005


Signed-off-by: Tom Duffy <tduffy at sun.com>

Index: linux-kernel-new/dat-provider/dapl_openib_cm.c
===================================================================
--- linux-kernel-new/dat-provider/dapl_openib_cm.c	(revision 2462)
+++ linux-kernel-new/dat-provider/dapl_openib_cm.c	(working copy)
@@ -573,12 +573,14 @@ void dapl_ib_reinit_ep(struct dapl_ep *e
 
 	ia_ptr = ep_ptr->header.owner_ia;
 
-	//*** What if QP is connected?  Do we need to destroy the cm_id
-	//*** here as well, send a DREQ, REJ?  What cm_id state are we in?
-	//*** we may not care if we just destroy the cm_id
-	//*** ib_destroy_cm_id(ep_ptr->cm_handle);
-	//*** supporting this call may require setting the cm_handle to
-	//*** something like NULL wherever it is destroyed
+	/*
+	 * What if QP is connected?  Do we need to destroy the cm_id
+	 * here as well, send a DREQ, REJ?  What cm_id state are we in?
+	 * we may not care if we just destroy the cm_id
+	 * ib_destroy_cm_id(ep_ptr->cm_handle);
+	 * supporting this call may require setting the cm_handle to
+	 * something like NULL wherever it is destroyed
+	 */
 
 	ib_status = dapl_modify_qp_state_to_reset(ep_ptr->qp_handle);
 	if (ib_status < 0) {
@@ -660,8 +662,10 @@ u32 dapl_ib_setup_conn_listener(struct d
  */
 u32 dapl_ib_remove_conn_listener(struct dapl_ia *ia_ptr, struct dapl_sp *sp_ptr)
 {
-	//*** This will hang if called from CM thread context...
-	//*** Move back to using WQ...
+	/*
+	 * This will hang if called from CM thread context...
+	 * Move back to using WQ...
+	 */
 	if (sp_ptr->cm_srvc_handle != NULL) {
 		ib_destroy_cm_id(sp_ptr->cm_srvc_handle);
 		sp_ptr->cm_srvc_handle = NULL;




More information about the general mailing list