[openib-general] [PATCH 1/2] IB: fix potential ib_umad leak

Roland Dreier roland at topspin.com
Tue May 24 15:20:57 PDT 2005


Free all unclaimed MAD receive buffers when userspace closes our file
so we don't leak memory.

Signed-off-by: Roland Dreier <roland at topspin.com>

---

 drivers/infiniband/core/user_mad.c |    4 ++++
 1 files changed, 4 insertions(+)



--- linux-git.orig/drivers/infiniband/core/user_mad.c	2005-05-24 15:11:25.795151912 -0700
+++ linux-git/drivers/infiniband/core/user_mad.c	2005-05-24 15:17:39.800453121 -0700
@@ -499,6 +499,7 @@
 static int ib_umad_close(struct inode *inode, struct file *filp)
 {
 	struct ib_umad_file *file = filp->private_data;
+	struct ib_umad_packet *packet, *tmp;
 	int i;
 
 	for (i = 0; i < IB_UMAD_MAX_AGENTS; ++i)
@@ -507,6 +508,9 @@
 			ib_unregister_mad_agent(file->agent[i]);
 		}
 
+	list_for_each_entry_safe(packet, tmp, &file->recv_list, list)
+		kfree(packet);
+
 	kfree(file);
 
 	return 0;




More information about the general mailing list