[openib-general] [PATCH] mthca, ibverbs userspace readability
Roland Dreier
roland at topspin.com
Thu May 26 12:28:40 PDT 2005
Roland> This patch seems to consist mostly of replacing tabs with
Roland> 8 spaces. Why is that an improvement for readability?
Bernhard> It does indeed. But with the patch, it's easier to read
Bernhard> and code for. Also, there are a couple of fixes for
Bernhard> super-long lines, which are extremely disturbing if you
Bernhard> happen to code userspace while referencing those headers
Bernhard> :-/
I'm not going to pursue a tabs vs. spaces argument any further. For
any code that I maintain, we're going to continue to indent using tabs.
If you can break out the other changes, I'll take a look. However,
I'm not that interested in breaking 85-character lines into two
lines-- to me saving vertical space is more useful than obeying a
strict 80-column limit.
- R.
More information about the general
mailing list