[openib-general] [PATCH][kdapl] fix fatal bug in triger the evd upcall

Itamar itamar at mellanox.co.il
Sun May 29 04:43:38 PDT 2005


Hi James,
	
This patch fix a fatal bug that exist in current lastet bits in kdapl (svn rev 2507)
As you can see we need to triger the upcall when dapl_evd_dequeue return with good status
and quit the method when dapl_evd_dequeue return with non zero status which mean queue is empty.
In the current bits no kdapltest can run even the simple quit test.

Please in the future before you commit changes to the svn run a simple regression.
Any way with this patch the code is working again.

fix fatal bug in triger the evd upcall 
Signed-off-by: Itamar Rabenstein <itamar at mellanox.co.il>

Index: dapl_cno_util.c
===================================================================
--- dapl_cno_util.c	(revision 2509)
+++ dapl_cno_util.c	(working copy)
@@ -115,12 +115,8 @@
 
 	for (;;) {
 		status = dapl_evd_dequeue((DAT_EVD_HANDLE)evd, &event);
-		if (DAT_SUCCESS == status) {
-			dapl_dbg_log(DAPL_DBG_TYPE_ERR, 
-				     "dapl_evd_dequeue failed: %x\n", status);
+		if (DAT_SUCCESS != status)
 			return;
-		}
-
 		cno->cno_upcall.upcall_func(cno->cno_upcall.instance_data,
 					    &event, FALSE);
 	}
-- 
Itamar



More information about the general mailing list