[openib-general] Re: [PATCH] Osmtest - update command options + vapi fix

[Hal Rosenstock]

Hi Liran,

On Tue, 2005-11-01 at 06:14, Liran Sorani wrote:
> Hi , Hal .
> We've decided to keep and maintain Osmtest in the main trunk , since
> it is not only a test but a tool to validate SA/SM.

I'm not sure I see the difference. It is a test tool which validates
SA/SM. Other tools validate other components. Anyhow, I will apply the
patch.

> The following is a small patch for the follwoing :
> 1. Support old form of running osmtest , i.e  instead of -g=<port
> guid> , use -g <port guid> and add '-p' option to display current
> available port guids.
> 
> 2. Support Vapi stack.
> 3. Update Service flow (Update one of the service lease checks from 1
> sec to 4 sec).
> 4. Ident switch-case) issues in main.c 
> 
> Thanks , Liran .

The patch for main.c appears to be line wrapped:
patching file main.c
patch: **** malformed patch at line 34: value\n"
I only need that part of the patch.

> Signed-off-by:  Liran Sorani <liran at mellanox.co.il>

[snip...]

> Index: Makefile.am
> ===================================================================
> --- Makefile.am (revision 3928)
> +++ Makefile.am (working copy)
> @@ -13,9 +13,11 @@
>  bin_PROGRAMS = osmtest 
>  osmtest_SOURCES = main.c osmtest.c osmt_service.c osmt_slvl_vl_arb.c
> \
>                  osmt_multicast.c osmt_inform.c
> -
> +if OSMV_VAPI
> +osmtest_SOURCES = osmt_mtl_regular_qp.c

Shouldn't this be:

osmtest_SOURCES += osmt_mtl_regular_qp.c

-- Hal

> +endif
>  osmtest_CFLAGS = -Wall $(OSMV_CFLAGS) -DVENDOR_RMPP_SUPPORT
> $(DBGFLAGS)
> -osmtest_LDADD = -L../complib -L../libvendor -L../opensm -L$(libdir) \
> +osmtest_LDADD = -L../complib -L../libvendor -L../opensm -L$(libdir)
> -L. \
>         $(OSMV_LDADD) -lopensm -losmcomp -losmvendor
>  
>  osmtest_LDFLAGS = -Wl,--rpath -Wl,$(libdir) -lpthread  -L../opensm
> 
> 
> 
> >       Liran Sorani
> >       Mellanox Technologies LTD.
> >       mailto:liran at mellanox.co.il
> >       Phone: +972(4)9097200 Ext: 214
> >       Israel, Yokneam P.O.B 586 ZIP 20692
> > 
> > 
>