[openib-general] Re: [RFC] patch to export userspace to kernel QP attribute structure

[Roland Dreier]

Seems OK but maybe we should create a new file (uverbs_marshall.c?)
rather than dumping more stuff into uverbs_cmd.c.  That file is big
enough as it is.

Also:

    > --- include/rdma/ib_user_verbs.h	(revision 3947)
    > +++ include/rdma/ib_user_verbs.h	(working copy)
    > @@ -38,6 +38,7 @@
    >  #define IB_USER_VERBS_H
    >  
    >  #include <linux/types.h>
    > +#include <rdma/ib_verbs.h>

    [snip]

    > +void ib_copy_qp_attr_to_user(struct ib_uverbs_qp_attr *dst,
    > +			     struct ib_qp_attr *src);

I very carefully made ib_user_verbs.h a file that did not include any
kernel internals and could be safely included from userspace.  So this
needs to go in a different file (probably just ib_verbs.h is fine).

 - R.