[openib-general] Re: [PATCH] fix page_size_cap value in ib_query_device for mellanox provider

[Michael S. Tsirkin]

Quoting Roland Dreier <rolandd at cisco.com>:
> Subject: Re: [PATCH] fix page_size_cap value in ib_query_device for mellanox provider
> 
> Can we just use something like this instead?  I don't think we need
> the comments talking about the semantics of page_size_cap, since we
> don't say what any other field means.

This was intended more as a clarification for you.
I think its fine to remove this comment if you think its clear
that _cap name means that its a bit mask.

> And I don't see what casting mdev->limits.page_size_cap to u64
> accomplishes -- it will get promoted to u64 anyway, since
> props->page_size_cap is a u64.
> 
>  - R.

Makes sense, to me.

-- 
MST