[openib-general][PATCH] local device search with sourceaddresswildcard

[Steve Wise]

i misunderstood.

I didn't realize ip_resolve_local() will fail if the address it a remote 
address.

nevermind...

:-\



----- Original Message ----- 
From: "Fab Tillier" <ftillier at silverstorm.com>
To: "'Steve Wise'" <swise at opengridcomputing.com>; "Sean Hefty" 
<mshefty at ichips.intel.com>; "Tom Tucker" <tom at opengridcomputing.com>
Cc: <openib-general at openib.org>
Sent: Friday, November 04, 2005 12:33 PM
Subject: RE: [openib-general][PATCH] local device search with 
sourceaddresswildcard


> From: Steve Wise [mailto:swise at opengridcomputing.com]
> Sent: Friday, November 04, 2005 10:23 AM
>
> ----- Original Message -----
> From: "Sean Hefty" <mshefty at ichips.intel.com>
> To: "Tom Tucker" <tom at opengridcomputing.com>
> Cc: <openib-general at openib.org>
>
> > Tom Tucker wrote:
> >> Sean:
> >>
> >> I was looking through ip_resolve_local and it looks to me like
> >> if the source address is 0, it will end up getting set to the
> >> destination IP instead of the IP address of the local interface.
> >
> > The intent of ip_resolve_local() is to check if a given destination
> > address is on the local system.  If it is and no source address is
> > specified, then the source address is set to the same address as the
> > destination.
> >
>
> This doesn't sound correct to me.  The src ip address is supposed to 
> be
> the local ip address to be used for establishing the connection.  If 
> you
> set it to the destination address, then you'd end up passing that
> address to the peer in the private data, and that is incorrect...

If the destination address is on the local system, then the user is 
establishing
a loopback connection.  I think that if the user didn't specify a source
address, returning the same address as the destination should give the 
proper
results.

For loopback connections, source and destination can (and will likely) 
be the
same.

- Fab