[openib-general] [PATCH] sdp zero copy support

Roland Dreier rolandd at cisco.com
Fri Nov 4 12:10:04 PST 2005


I haven't read the code yet, but:

    > +config INFINIBAND_SDP_SEND_ZCOPY
    > +	bool "Sockets Direct Protocol Zero Copy Send support"
    > +	depends on INFINIBAND_SDP
    > +	default y
    > +	---help---
    > +	  This option enables Zero Copy support for send_msg transactions.
    > +
    > +config INFINIBAND_SDP_RECV_ZCOPY
    > +	bool "Sockets Direct Protocol Zero Copy Receive support"
    > +	depends on INFINIBAND_SDP && INFINIBAND_SDP_SEND_ZCOPY
    > +	default y
    > +	---help---
    > +	  This option enables Zero Copy support for recv_msg transactions.

Why would I ever say 'n'?  I think we should either get rid of these
config options, or if there is a reason for them, explain it better in
the help text.

 - R.



More information about the general mailing list