[openib-general] Re: [PATCHv1] userspace CMA

Roland Dreier rolandd at cisco.com
Thu Nov 10 13:52:34 PST 2005


The libibverbs bits look mostly OK but:

 . I don't see a file sa_kern-abi.h anywhere -- I think you forgot to
   add it.  Also, please name it sa-kern-abi.h (ie all '-'s) -- mixed
   underscores and dashes are just too hard to type and look weird.

   Or did you just put everything in kern-abi.h?  That's fine too,
   just remove the sa_kern-abi.h references.

 . Please add a ChangeLog entry covering the libibverbs changes.

 - R.



More information about the general mailing list