[openib-general] Re: [PATCH] user_mad: fix mad header parsing
Michael S. Tsirkin
mst at mellanox.co.il
Mon Nov 28 10:12:49 PST 2005
Quoting r. Roland Dreier <rolandd at cisco.com>:
> Subject: Re: [PATCH] user_mad: fix mad header parsing
>
> > Looks like there's a bug in user_mad.c.
> > Does the following make sense?
>
> Seems right to me. Sean?
>
> > Signed-off-by: Michael S. Tsirkin <mst at mellanox.co.il>
> > Signed-off-by: Jack Morgenstein <jackm at mellanox.co.il>
>
> I think you are passing on a patch that Jack wrote.
Yes.
> If that is true,
> then these lines are in the wrong order -- you always add your
> Signed-off-by: line at the bottom of the chain, so I think it should
> really be:
>
> Signed-off-by: Jack Morgenstein <jackm at mellanox.co.il>
> Signed-off-by: Michael S. Tsirkin <mst at mellanox.co.il>
>
> and then when I send it upstream, it becomes
>
> Signed-off-by: Jack Morgenstein <jackm at mellanox.co.il>
> Signed-off-by: Michael S. Tsirkin <mst at mellanox.co.il>
> Signed-off-by: Roland Dreier <rolandd at cisco.com>
>
> and so on.
>
> - R.
>
OK, good to know.
--
MST
More information about the general
mailing list