[openib-general] Re: error handling in ipoib_open

[Roland Dreier]

    Michael> Roland, ipoib_open error handling looks strange.  dont we
    Michael> need to e.g. call ipoib_ib_dev_stop if ipoib_ib_dev_up
    Michael> returns an error?

You're right.  I just committed this:

--- infiniband/ulp/ipoib/ipoib_main.c	(revision 4215)
+++ infiniband/ulp/ipoib/ipoib_main.c	(working copy)
@@ -94,8 +94,10 @@ int ipoib_open(struct net_device *dev)
 	if (ipoib_ib_dev_open(dev))
 		return -EINVAL;
 
-	if (ipoib_ib_dev_up(dev))
+	if (ipoib_ib_dev_up(dev)) {
+		ipoib_ib_dev_stop(dev);
 		return -EINVAL;
+	}
 
 	if (!test_bit(IPOIB_FLAG_SUBINTERFACE, &priv->flags)) {
 		struct ipoib_dev_priv *cpriv;